Skip to content

Fix stale data after navigation despite revalidation#95439

Open
gaearon wants to merge 2 commits into
canaryfrom
fix-stale-queue-tail
Open

Fix stale data after navigation despite revalidation#95439
gaearon wants to merge 2 commits into
canaryfrom
fix-stale-queue-tail

Conversation

@gaearon

@gaearon gaearon commented Jul 2, 2026 •

Copy link
Copy Markdown
Contributor

Claude noticed this while working on #95391.

Basically, the queue's React state always gets updated in the order of dispatching. So if a navigation displaced pending actions, it's the navigation's promise that was last. So when the pending action runs after it, that action's state is no longer taken into account, even if it revalidated. This is why the new data won't reflect on the screen.

With the fix, the final state is properly reflected.

Test Plan

New test, which was red before the fix.

Also tried it on a mini-app.

Before:

before.mov

After:

after.mov

How

We re-render at the end with the final queue state — if we know it was preempted.

@github-actions

github-actions Bot commented Jul 2, 2026 •

Copy link
Copy Markdown
Contributor

Tests Passed

Commit: c8fa288

@github-actions

github-actions Bot commented Jul 2, 2026 •

Copy link
Copy Markdown
Contributor

Stats from current PR

🔴 1 regression, 2 improvements

Metric Canary PR Change Trend
Turbo Build Time 4.976s 5.270s 🔴 +294ms (+6%) ▁▁▁▂▁
Webpack Build Time 25.537s 24.581s 🟢 956ms (-4%) ▇█▄▆▄
Webpack Build Time (cached) 25.826s 24.971s 🟢 855ms (-3%) ▇█▃▅▆
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 812ms 813ms ✓ ▁▂▁▂▁
Cold (Ready in log) 781ms 789ms ✓ ▁▁▁▁▁
Cold (First Request) 1.307s 1.307s ✓ ▂▂▁▂▂
Warm (Listen) 814ms 813ms ✓ ▂▂▁▂▁
Warm (Ready in log) 782ms 787ms ✓ ▁▁▁▁▁
Warm (First Request) 589ms 607ms ✓ ▁▁▁▁▂
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 813ms 760ms ✓ ██▁██
Cold (Ready in log) 777ms 766ms ✓ ██▅▇▆
Cold (First Request) 3.355s 3.377s ✓ ▇█▄▆▅
Warm (Listen) 813ms 762ms ✓ ██▁██
Warm (Ready in log) 772ms 762ms ✓ ██▃▆█
Warm (First Request) 3.409s 3.345s ✓ ▇▅▁▄▆

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.976s 5.270s 🔴 +294ms (+6%) ▁▁▁▂▁
Cached Build 5.081s 5.271s ✓ ▁▁▁▂▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 25.537s 24.581s 🟢 956ms (-4%) ▇█▄▆▄
Cached Build 25.826s 24.971s 🟢 855ms (-3%) ▇█▃▅▆
node_modules Size 514 MB 514 MB ✓ █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles
Canary PR Change
034zmn7v4tsj3.js gzip 53.5 kB N/A -
03gmyxr7dukvs.js gzip 10.3 kB N/A -
03tt4thpkf_py.js gzip 156 B N/A -
040t1q17lo593.js gzip 8.77 kB N/A -
0bb0vtp8dwsez.js gzip 450 B N/A -
0cz1d0mv5g_q7.js gzip 39.4 kB 39.4 kB ✓
0nxqz3q165m2l.js gzip 220 B N/A -
0qr-1tnb7_hg5.js gzip 5.72 kB N/A -
0uilzvklme4ea.js gzip 8.76 kB N/A -
0v0wmwk2-r35h.js gzip 160 B N/A -
0z0y83mfx-l-h.js gzip 10 kB N/A -
13mqkxitd_mp-.js gzip 156 B N/A -
15ok8ydf274z0.js gzip 10.6 kB N/A -
16cqqcigykfea.js gzip 13.6 kB N/A -
17h18zxt1915l.js gzip 1.46 kB N/A -
1elt1qium-r2m.css gzip 115 B 115 B ✓
1fq1h7dxad4cv.js gzip 9.44 kB N/A -
1fym-adbk_69_.js gzip 13.1 kB N/A -
1gav7nfh4y8ln.js gzip 8.76 kB N/A -
1gvnrogz-nk26.js gzip 157 B N/A -
1nm0awhqye5p8.js gzip 154 B N/A -
1nwugjw0i93us.js gzip 156 B N/A -
1rhk5y2vvnyud.js gzip 169 B N/A -
1s8oolynvqjk6.js gzip 155 B N/A -
1zxeepg375efo.js gzip 14.3 kB N/A -
2_1mg3cv86xn-.js gzip 156 B N/A -
29du04jy1wjq7.js gzip 7.65 kB N/A -
2ayx44yp1i407.js gzip 71 kB N/A -
2rypqffktcxqh.js gzip 8.69 kB N/A -
2uqsizxtehgqf.js gzip 8.79 kB N/A -
2vzktdqwbijqc.js gzip 8.74 kB N/A -
2y2m2aowi7lgb.js gzip 161 B N/A -
38wdlbypioegf.js gzip 153 B N/A -
3c244akvx_-be.js gzip 8.74 kB N/A -
3czh4acsysft-.js gzip 155 B N/A -
3dmlemitx3ef3.js gzip 2.29 kB N/A -
3j3wt_5y9cpjx.js gzip 65.5 kB N/A -
3oq7la2gelh4n.js gzip 155 B N/A -
3umfpv6uzk6cg.js gzip 13.2 kB N/A -
4237vdj6eyslt.js gzip 8.7 kB N/A -
turbopack-0_..0e0k.js gzip 3.74 kB N/A -
turbopack-00..ji86.js gzip 3.74 kB N/A -
turbopack-09..5el4.js gzip 3.74 kB N/A -
turbopack-0o..iy-c.js gzip 3.74 kB N/A -
turbopack-0s..7rtz.js gzip 3.74 kB N/A -
turbopack-0v..ep2g.js gzip 3.74 kB N/A -
turbopack-0x..-y72.js gzip 3.74 kB N/A -
turbopack-11..68z6.js gzip 3.75 kB N/A -
turbopack-1w..lt0k.js gzip 3.74 kB N/A -
turbopack-2b..8rwo.js gzip 3.72 kB N/A -
turbopack-2l..nquv.js gzip 3.74 kB N/A -
turbopack-2w..sjcd.js gzip 3.74 kB N/A -
turbopack-32..ss4y.js gzip 3.74 kB N/A -
turbopack-3t..7tg5.js gzip 3.74 kB N/A -
00tc16j5-eos9.js gzip N/A 1.46 kB -
04k1dnw6y-sgq.js gzip N/A 160 B -
0gaw1gmpwuwkn.js gzip N/A 8.8 kB -
0n8vgrgx6gsx2.js gzip N/A 65.5 kB -
0rbtcmwiuz-3x.js gzip N/A 157 B -
1_jfzs24krjbo.js gzip N/A 156 B -
12zyjjmq4oad1.js gzip N/A 5.72 kB -
1cfirxwnd7m9h.js gzip N/A 161 B -
1d14swk91dglf.js gzip N/A 157 B -
1k9cc4-gpa2cx.js gzip N/A 13.1 kB -
1n59uogejo81s.js gzip N/A 10.3 kB -
1npei3hlexdv3.js gzip N/A 9.99 kB -
1r9saocuyyl10.js gzip N/A 53.5 kB -
1ssuiwj_rnpc5.js gzip N/A 8.77 kB -
1wb808_e_-w3u.js gzip N/A 155 B -
2-phc9obd3nyd.js gzip N/A 8.77 kB -
23gji-p3v7u-m.js gzip N/A 14.3 kB -
24utq57r3l1cw.js gzip N/A 8.7 kB -
28r3lfbanlqsz.js gzip N/A 154 B -
2fhjq6ek3srmr.js gzip N/A 8.69 kB -
2g0t7upz_v-hf.js gzip N/A 10.6 kB -
2ia9qqy99aie9.js gzip N/A 13.6 kB -
2oza28kdqvoay.js gzip N/A 8.74 kB -
2petq82fjj2-5.js gzip N/A 71 kB -
2rv500jdndh2l.js gzip N/A 156 B -
2ty8muxbqewy-.js gzip N/A 154 B -
2zh8-mmhujy8o.js gzip N/A 2.29 kB -
30h_m0irj-q6p.js gzip N/A 221 B -
37ejbfx1u9lpo.js gzip N/A 8.75 kB -
38c63ct4i1cy7.js gzip N/A 449 B -
396nht7itx-uq.js gzip N/A 153 B -
3fospa9508caf.js gzip N/A 155 B -
3hd1us4ordyc9.js gzip N/A 13.2 kB -
3jimpal3lvz5e.js gzip N/A 9.44 kB -
3rc2knzmbwc3u.js gzip N/A 7.65 kB -
3sopw705rkml5.js gzip N/A 157 B -
3urjgcevdqj17.js gzip N/A 169 B -
3wb4pe4z4-aim.js gzip N/A 8.77 kB -
turbopack-05..bfnr.js gzip N/A 3.74 kB -
turbopack-07..idrr.js gzip N/A 3.74 kB -
turbopack-08..mpl7.js gzip N/A 3.74 kB -
turbopack-0s..944p.js gzip N/A 3.74 kB -
turbopack-1k..sc_y.js gzip N/A 3.74 kB -
turbopack-2_..ibpn.js gzip N/A 3.74 kB -
turbopack-2l..lm-v.js gzip N/A 3.74 kB -
turbopack-3-..hbud.js gzip N/A 3.72 kB -
turbopack-37..fdi3.js gzip N/A 3.75 kB -
turbopack-39..5fjh.js gzip N/A 3.74 kB -
turbopack-3o..3o_l.js gzip N/A 3.74 kB -
turbopack-3t..fc26.js gzip N/A 3.74 kB -
turbopack-3u..0ekr.js gzip N/A 3.74 kB -
turbopack-40..fson.js gzip N/A 3.74 kB -
Total 466 kB 466 kB ⚠️ +30 B

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 731 B 724 B ✓
Total 731 B 724 B ✅ -7 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 433 B 436 B ✓
Total 433 B 436 B ⚠️ +3 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2486.HASH.js gzip 169 B N/A -
3146-HASH.js gzip 63.6 kB N/A -
39fcf99b-HASH.js gzip 62.9 kB N/A -
8443-HASH.js gzip 4.68 kB N/A -
9431-HASH.js gzip 5.62 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB ✓
main-app-HASH.js gzip 256 B 255 B ✓
main-HASH.js gzip 39.6 kB 40.1 kB 🔴 +455 B (+1%)
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
6105-HASH.js gzip N/A 5.63 kB -
764.HASH.js gzip N/A 169 B -
8898-HASH.js gzip N/A 63.1 kB -
9597-HASH.js gzip N/A 4.65 kB -
e1ccab69-HASH.js gzip N/A 62.9 kB -
Total 238 kB 238 kB ✅ -32 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 182 B ✓
css-HASH.js gzip 335 B 335 B ✓
dynamic-HASH.js gzip 1.8 kB 1.8 kB ✓
edge-ssr-HASH.js gzip 255 B 254 B ✓
head-HASH.js gzip 351 B 349 B ✓
hooks-HASH.js gzip 384 B 384 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 259 B 259 B ✓
link-HASH.js gzip 2.49 kB 2.49 kB ✓
routerDirect..HASH.js gzip 319 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 313 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.96 kB 7.95 kB ✅ -6 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 127 kB 127 kB ✓
page.js gzip 284 kB 284 kB ✓
Total 410 kB 411 kB ⚠️ +1.11 kB
Middleware
Canary PR Change
middleware-b..fest.js gzip 616 B 618 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 45.3 kB 44.9 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 46.9 kB 46.5 kB ✅ -400 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 719 B 719 B ✓
Total 719 B 719 B ✓
Build Cache
Canary PR Change
0.pack gzip 4.75 MB 4.73 MB 🟢 11.2 kB (0%)
index.pack gzip 117 kB 116 kB ✓
index.pack.old gzip 116 kB 117 kB 🔴 +1.51 kB (+1%)
Total 4.98 MB 4.97 MB ✅ -10.7 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 364 kB 364 kB ✓
app-page-exp..prod.js gzip 200 kB 200 kB ✓
app-page-tur...dev.js gzip 364 kB 364 kB ✓
app-page-tur..prod.js gzip 200 kB 200 kB ✓
app-page-tur...dev.js gzip 360 kB 360 kB ✓
app-page-tur..prod.js gzip 198 kB 198 kB ✓
app-page.run...dev.js gzip 360 kB 361 kB ✓
app-page.run..prod.js gzip 198 kB 198 kB ✓
app-route-ex...dev.js gzip 79.1 kB 79.1 kB ✓
app-route-ex..prod.js gzip 53.6 kB 53.6 kB ✓
app-route-tu...dev.js gzip 79.1 kB 79.1 kB ✓
app-route-tu..prod.js gzip 53.6 kB 53.6 kB ✓
app-route-tu...dev.js gzip 78.7 kB 78.7 kB ✓
app-route-tu..prod.js gzip 53.4 kB 53.4 kB ✓
app-route.ru...dev.js gzip 78.7 kB 78.7 kB ✓
app-route.ru..prod.js gzip 53.4 kB 53.4 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 45.2 kB 45.2 kB ✓
pages-api-tu..prod.js gzip 33.9 kB 33.9 kB ✓
pages-api.ru...dev.js gzip 45.2 kB 45.2 kB ✓
pages-api.ru..prod.js gzip 33.9 kB 33.9 kB ✓
pages-turbo....dev.js gzip 54.7 kB 54.7 kB ✓
pages-turbo...prod.js gzip 39.6 kB 39.6 kB ✓
pages.runtim...dev.js gzip 54.6 kB 54.6 kB ✓
pages.runtim..prod.js gzip 39.5 kB 39.5 kB ✓
server.runti..prod.js gzip 65 kB 65 kB ✓
use-cache-pr...dev.js gzip 71.3 kB 71.3 kB ✓
use-cache-pr...dev.js gzip 71.3 kB 71.3 kB ✓
use-cache-pr...dev.js gzip 69.6 kB 69.6 kB ✓
use-cache-pr...dev.js gzip 69.6 kB 69.6 kB ✓
Total 3.47 MB 3.47 MB ⚠️ +251 B
📝 Changed Files (8 files)

Files with changes:

  • app-page-exp..ntime.dev.js
  • app-page-exp..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page.runtime.dev.js
  • app-page.runtime.prod.js
View diffs
app-page-exp..ntime.dev.js

Diff too large to display

app-page-exp..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js

Diff too large to display

app-page-tur..time.prod.js
failed to diff
app-page-tur..ntime.dev.js

Diff too large to display

app-page-tur..time.prod.js

Diff too large to display

app-page.runtime.dev.js

Diff too large to display

app-page.runtime.prod.js

Diff too large to display

📎 Tarball URL
https://vercel-packages.vercel.app/next/commits/c8fa28801e7f647af19939cb5cbc471ad7778379/next

Commit: c8fa288

gaearon added 2 commits July 3, 2026 01:19
React renders the most recently dispatched router state. A preempting
navigation is dispatched after the actions it inherits from the displaced
action, but settles before them, so the states those actions produce
never render: the queue's internal state advances while the UI stays on
the navigation's state until some later dispatch re-renders it. Most
visibly, a revalidating action queued behind a navigation applies its
refreshed data internally but the screen never updates.

When the queue drains after a preemption, render the queue's state. At
that point nothing is pending, so publishing a plain value cannot
supersede an unsettled state promise, and it is published before any
deferred refresh is dispatched so the refresh remains the newest state.
@gaearon gaearon force-pushed the fix-stale-queue-tail branch from 1638c86 to c8fa288 Compare July 3, 2026 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant