[docs] Update "Handling a Custom Service Worker" in the CRA migration docs#95434
Open
sampoder wants to merge 1 commit into
Open
[docs] Update "Handling a Custom Service Worker" in the CRA migration docs#95434sampoder wants to merge 1 commit into
Service Worker" in the CRA migration docs#95434sampoder wants to merge 1 commit into
Conversation
Contributor
Stats skippedCommit: 42eec9e |
Contributor
Tests PassedCommit: 42eec9e |
f235e2c to
721dcb6
Compare
660ebf8 to
42eec9e
Compare
| If you used CRA’s service worker (e.g., `serviceWorker.js` from `create-react-app`), you can register this service worker using the following syntax: | ||
|
|
||
| ```ts | ||
| await navigator.serviceWorker.register(new URL('../serviceWorker.js', import.meta.url), ...) |
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #95431; I think we can directly mention this in this guide to make people's lives easier (the PWA guide is quite long for this small chunk of code)