examples: remove stale GraphCMS env log#95419
Open
msh01 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove a stale debug log from the
cms-graphcmsexample that printedprocess.env.NEXT_EXAMPLE_CMS_GCMS_PROJECT_IDwhen GraphCMS returned errors. That variable is not configured by the example, so the log only emittedundefined; the actual GraphCMS errors are still logged.Verification
rg -n "NEXT_EXAMPLE_CMS_GCMS_PROJECT_ID|console\.error\(json\.errors\)" examples/cms-graphcms/lib/graphcms.js examples/cms-graphcms/README.md examples/cms-graphcms/.env.local.examplegit diff --checkcms-graphcmsrequires GraphCMS credentials)